Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

area schedule support 2018 #2013

Merged
merged 3 commits into from Aug 13, 2018

Conversation

Projects
None yet
6 participants
@ksobon
Copy link
Contributor

ksobon commented Apr 18, 2018

Purpose

This PR addresses this issue: #1704

image

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • Snapshot of UI changes, if any.

Reviewers

@mjkkirschner @smangarole, @jnealb

FYIs

This was submitted before but was closed due to inactivity and lack of tests. Let's see if this works. It was tested:

image

@ksobon ksobon changed the title area schedule support area schedule support 2018 Apr 18, 2018

@QilongTang

This comment has been minimized.

Copy link
Contributor

QilongTang commented Apr 18, 2018

@ksobon Great work. But also be aware DynamoRevit work will be taken over by Revit team. I would @philxia1 @AndyDu1985 @ZiyunShang in the future for related work

@ksobon

This comment has been minimized.

Copy link
Contributor Author

ksobon commented Apr 18, 2018

Really? @kronz @Racel @mjkkirschner I will miss you guys.

@QilongTang

This comment has been minimized.

Copy link
Contributor

QilongTang commented Apr 18, 2018

@ksobon Yes, DynamoRevit 2.0 should be the last release only handled by Dynamo team, in the future it will be joint effort.

@smangarole

This comment has been minimized.

Copy link
Contributor

smangarole commented Apr 18, 2018

Thanks @ksobon. I am glad you were able to run the RTF tests.

@Racel

This comment has been minimized.

Copy link
Contributor

Racel commented Apr 18, 2018

@ksobon Don't worry. We will still be here, but focused on working on Dynamo Core only. The Revit team is just taking over the DynamoRevit repo :)

@mjkkirschner

This comment has been minimized.

Copy link
Member

mjkkirschner commented Aug 10, 2018

@ksobon this and the cherry picks look good to me - thanks for adding the new method, tests, and the general cleanup.

  • @philxia1 can we get this and the cherry pick branches for this PR merged? I am not sure how you want to handle the new master branch though?
@AndyDu1985

This comment has been minimized.

Copy link
Contributor

AndyDu1985 commented Aug 13, 2018

@ksobon, thank you for your contribution to Dynamo For Revit.

@AndyDu1985 AndyDu1985 merged commit 3911c31 into DynamoDS:Revit2018 Aug 13, 2018

@AndyDu1985

This comment has been minimized.

Copy link
Contributor

AndyDu1985 commented Aug 13, 2018

@ZiyunShang will cherry pick this PR to other branches.

@ksobon ksobon deleted the ksobon:area-schedule-2018 branch Aug 13, 2018

AndyDu1985 added a commit that referenced this pull request Aug 14, 2018

Merge pull request #2113 from ZiyunShang/master
Merge pull request #2013 from ksobon/area-schedule-2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.