Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re New node - Element.GetGeometry #2924

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

dnenov
Copy link
Contributor

@dnenov dnenov commented Jun 2, 2023

Purpose

This PR is a redo of #2918 pointing to master branch.

Part of the new nodes PRs, this small PR adds a new Element.GetGeometry node, which incorporates an input for Detail Level.

getgeometry

  • added new node Element.GetGeometry that has detail level

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • Snapshot of UI changes, if any.

Reviewers

@reddyashish
@Amoursol

FYIs

@Mikhinja

@dnenov dnenov changed the title Recreated repository pointing to master New node - Element.GetGeometry - redo Jun 2, 2023
@dnenov dnenov changed the title New node - Element.GetGeometry - redo Re New node - Element.GetGeometry Jun 2, 2023
@dnenov dnenov mentioned this pull request Jun 2, 2023
5 tasks
@Mikhinja
Copy link
Collaborator

Mikhinja commented Jun 6, 2023

Note: Although the image in this PR shows the detail level given from a code block, there already exists a drop down node to get the detail level strings, called "Detail Level".

@Mikhinja Mikhinja merged commit 134aa06 into DynamoDS:master Jun 6, 2023
@dnenov
Copy link
Contributor Author

dnenov commented Jun 6, 2023

Note: Although the image in this PR shows the detail level given from a code block, there already exists a drop down node to get the detail level strings, called "Detail Level".

Hi @Mikhinja - we had trouble using the dedicated Detail Level drop-down node in our early tests (it would produce a 'null' result), but in consequent ones, we've successfully utilized it. Element.GetGeometry works with both the Detail Level node and string input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants