-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AGD-1489 #52
AGD-1489 #52
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mrahmaniasl 👋 , hope you don't mind I've left a few notes below, mostly concerning keeping the wording accessible.
* The computer generates many designs \(not just one\). | ||
* The computer finds a set of optimal solutions that satisfy the designer’s multiple competing goals. | ||
* The computer helps designer to explore the design space and generate multiple design options \(not just one\). | ||
* The computer enables designer to find a set of optimal solutions that satisfies multiple comepeting goals. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few spelling/grammar issues fixed below :
* The computer enables designer to find a set of optimal solutions that satisfies multiple comepeting goals. | |
* The computer enables the designer to find a set of optimal solutions that satisfy multiple competing goals. |
Though I would suggest this re-wording makes it less clear where those multiple goals
come from.
@@ -15,6 +13,7 @@ We see generative design as: | |||
Generative design is a specific application of the computational design approach, with the following distinctions: | |||
|
|||
* The designer defines goals to achieve a design \(rather than the exact steps\). | |||
* The computer generates many designs \(not just one\). | |||
* The computer finds a set of optimal solutions that satisfy the designer’s multiple competing goals. | |||
* The computer helps designer to explore the design space and generate multiple design options \(not just one\). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
explore design space
- I would suggest this is too technical a term and not all readers would be familiar with what it means (as it's an intro, it's not been introduced yet)
- it might also be redundant since
enables the designer to find optimal solutions
below is essentially the same thing. Perhaps this line could only refer to thegeneration
aspect ?
a small grammar issue :
- helps
the
designer
* The computer finds a set of optimal solutions that satisfy the designer’s multiple competing goals. | ||
* The computer helps designer to explore the design space and generate multiple design options \(not just one\). | ||
* The computer enables designer to find a set of optimal solutions that satisfies multiple comepeting goals. | ||
* The designer evaluates and compares multiple design scenarios to find a set of design options that fits design goals. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Mixed terminology makes things a bit less clear I think :
design scenarios
vsdesign options
used to refer to same thing - This sentence also seem to say the same thing as the one above
designer evaluates
might be mis-leading since theevaluate
wording is used throughout in a different context.Designer compares
should be enough, maybe it can simply be removed ?
@@ -15,6 +13,7 @@ We see generative design as: | |||
Generative design is a specific application of the computational design approach, with the following distinctions: | |||
|
|||
* The designer defines goals to achieve a design \(rather than the exact steps\). | |||
* The computer generates many designs \(not just one\). | |||
* The computer finds a set of optimal solutions that satisfy the designer’s multiple competing goals. | |||
* The computer helps designer to explore the design space and generate multiple design options \(not just one\). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The computer helps THE designer to explore....
* The computer finds a set of optimal solutions that satisfy the designer’s multiple competing goals. | ||
* The computer helps designer to explore the design space and generate multiple design options \(not just one\). | ||
* The computer enables designer to find a set of optimal solutions that satisfies multiple comepeting goals. | ||
* The designer evaluates and compares multiple design scenarios to find a set of design options that fits design goals. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The designer evaluates and compares multiple design scenarios to find a set of design options that fits THE design goals. .....but also I agree with Radu's comments. Could we just leave it out?
1. Right-click on each node used to drive the graph and ensure that the 'Is Input' option is ticked. | ||
1. Right-click on each node used to drive the graph and ensure that the 'Is Input' option is checked. | ||
2. Rename the node as explained above. | ||
2. For slider nodes set proper values for Min, Max, and Step values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should the last one be 3.?
1. Right-click on each node used to drive the graph and ensure that the 'Is Input' option is ticked. | ||
1. Right-click on each node used to drive the graph and ensure that the 'Is Input' option is checked. | ||
2. Rename the node as explained above. | ||
2. For slider nodes set proper values for Min, Max, and Step values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For slider nodes set values for Min, Max..... (take out "proper")
The graph consists of three cuboids with different variable parameters, such as height and location. The objectives of the graph are to find an option with minimal volume and maximum combined surface area. | ||
|
||
[Download Dynamo file](https://github.com/DynamoDS/RefineryPrimer/releases/download/samples-v2/04-01-02_Minimum-volume-and-maximum-surface.zip). | ||
This sample file is available in the most recent version of Generative Design tool. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...available in the most recent version of Generative Design in Revit.
@@ -0,0 +1,48 @@ | |||
# Minimum Volume and Maximum Surface | |||
|
|||
Thsi is a multi-objective optimization problem, with two competing objectives. This example consists of three cuboids with different variable parameters, such as height and location. The objectives of the graph are to find an option with minimal volume and maximum combined surface area. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This (typo)
|
||
Thsi is a multi-objective optimization problem, with two competing objectives. This example consists of three cuboids with different variable parameters, such as height and location. The objectives of the graph are to find an option with minimal volume and maximum combined surface area. | ||
|
||
This sample file is available in the most recent version of Generative Design tool. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
most recent version of Generative Design in Revit.
04-sample-workflows/04-02_architectural-workflows/04-02-01_building-mass-generator.md
Outdated
Show resolved
Hide resolved
@@ -10,7 +10,7 @@ This graph uses the optimize method to place objects in a room/space using a gri | |||
|
|||
Although a simplified approach, this graph can be used as the foundation to explore more complex and personalized criteria that relate specifically to your project or practice. | |||
|
|||
[Download workflow files](https://github.com/DynamoDS/RefineryPrimer/releases/download/samples-v2/04-02-04_Grid-object-placement.zip). | |||
This sample file is available in the most recent version of Generative Design tool. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...recent version of Generative Design in Revit.
@@ -14,7 +14,8 @@ This workflow is intended to be used with the 'Randomize' mode. Because of this, | |||
|
|||
With this workflow you can save time by quickly generating multiple scenes without having to manually place each element. | |||
|
|||
[Download workflow files](https://github.com/DynamoDS/RefineryPrimer/releases/download/samples-v2/04-02-05_Random-object-placement.zip). | |||
This sample file is available in the most recent version of Generative Design tool. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
....of Generative Design in Revit.
Hi @radumg Thanks for reviewing. Just to let you know, I am going to remove the graphs that are already shipped with GD from the release here to maintain them only at one place. |
AGD-1489: Fixes for main PR branch
…lding-mass-generator.md Co-authored-by: Radu Gidei <radumg@users.noreply.github.com>
👍 The only side-effects I can think of are :
Are these (in particular last point) an issue @lillismith ? |
Purpose
The goal of this PR is to update samples and other parts of the Primer with the required changes for the most recent Generative Design in Revit Release.
Changes:
1- Some issues in the document is addressed such as wrong screenshots or descriptions
2- Sample 01-01_Highest-point-of-a surface is updated
3- Sample01-02_Minimum-volume-and-maximum-surface is removed as it is duplicate of 3 box sample that is shipped with GD
4- Sample 02-01-Building-Generator is updated and study type is created.
5- Sample 02-02 Building positioning is updated.
6- Sample 02-03 Office-Layout is updated
7- Sample 02-04 Grid object is removed
8- Sample 02-05 Entourage placement is removed
TODO: Update files to be downloaded with all samples and update the release page
FYI TBD