i#1569 AArch64: Move assignments out of expressions in encode_gen.h. (#…

…2314) This patch fixes a coding style violation pointed out in #2309 in the auto-generated encode_gen.h.
DynamoRIO · Mar 30, 2017 · 3e18d73 · 3e18d73
1 parent d6d4faa
commit 3e18d73
Show file tree

Hide file tree

Showing 2 changed files with 674 additions and 338 deletions.
diff --git a/core/arch/aarch64/codec.py b/core/arch/aarch64/codec.py
@@ -183,8 +183,8 @@ def generate_encoder(patterns, opndsgen, opndtypes):
         pat1 = pats.pop()
         for p in pats:
             (b, m, mn, f) = p
-            c.append('        if ((enc = encode_opnds%s(pc, instr, 0x%08x)) != ENCFAIL)' %
-                     (f, b))
+            c.append('        enc = encode_opnds%s(pc, instr, 0x%08x);' % (f, b))
+            c.append('        if (enc != ENCFAIL)')
             c.append('            return enc;')
         (b, m, mn, f) = pat1
         c.append('        return encode_opnds%s(pc, instr, 0x%08x);' % (f, b))