Skip to content

Commit

Permalink
i#5844 Move x86 expand_scatter_gather to its own file (#6173)
Browse files Browse the repository at this point in the history
The existing drx_expand_scatter_gather() function is > 2000 lines of
code, including helper functions, and most of it is very x86 specific.

In preparation for writing the AArch64 version of this function, this
commit moves the x86 implementation of drx_expand_scatter_gather() out
of drx.c into its own architecture specific files, and creates dummy
implementations for other architectures.

The behaviour of the function should be unchanged on all platforms.

As we develop the AArch64 version of drx_expand_scatter_gather(), any
parts of the original x86 implementation which are usefull to both can
be pulled out into helper functions which are shared between both
architectures.

Issues: #5844, #5036, #3837
  • Loading branch information
jackgallagher-arm committed Jun 27, 2023
1 parent 0d1f742 commit fdb78af
Show file tree
Hide file tree
Showing 6 changed files with 2,611 additions and 2,377 deletions.
1 change: 1 addition & 0 deletions ext/drx/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ set(DynamoRIO_USE_LIBC OFF)
set(srcs
drx.c
drx_buf.c
scatter_gather_${ARCH_NAME}.c
# add more here
)

Expand Down
Loading

0 comments on commit fdb78af

Please sign in to comment.