Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rseq mangling does not support multiple app copies from drbbdup #5659

Closed
derekbruening opened this issue Sep 26, 2022 · 0 comments · Fixed by #5660
Closed

rseq mangling does not support multiple app copies from drbbdup #5659

derekbruening opened this issue Sep 26, 2022 · 0 comments · Fixed by #5660
Assignees
@derekbruening
Labels
Bug-AppCrash Component-DrMemtrace Google-Affecting

Comments

@derekbruening
Copy link
Contributor

I hit this, like in #5658, when using drbbdup cases with drmemtrace in larger apps that use rseq.

The rseq finalization is what assumes a single sequence: both in its instrlist search and in what it stores per fragment.
@derekbruening derekbruening self-assigned this Sep 26, 2022
derekbruening added a commit that referenced this issue Sep 26, 2022
@derekbruening
i#5659: Handle multiple app copies in rseq mangling
1757ea9 
Adds support for multiple app copies in rseq mangling finalization's
search for labels to fill in code cache PC's.

Adds support for multiple rseq regions in one fragment_t by expanding
the stored rseq_cs per fragment to become a list.

Adds "-trace_after_instrs 5K" to the tool.drcacheoff.rseq test to
exercise rseq with drbbdup.

Augments the attach/detach api.rseq test to use drmemtrace, which with
the forthcoming #2039 mode switches also hits this multi-rseq case.

Fixes #5659
@derekbruening derekbruening mentioned this issue Sep 26, 2022
Merged
derekbruening added a commit that referenced this issue Sep 28, 2022
@derekbruening
i#5659: Handle multiple app copies in rseq mangling (#5660)
f9dae92 
Adds support for multiple app copies in rseq mangling finalization's
search for labels to fill in code cache PC's.

Adds support for multiple rseq regions in one fragment_t by expanding
the stored rseq_cs per fragment to become a list.

Adds "-trace_after_instrs 5K" to the tool.drcacheoff.rseq test to
exercise rseq with drbbdup.

Augments the attach/detach api.rseq test to use drmemtrace, which with
the forthcoming #2039 mode switches also hits this multi-rseq case.

Fixes #5659
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derekbruening derekbruening

Labels
Bug-AppCrash Component-DrMemtrace Google-Affecting
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

i#5659: Handle multiple app copies in rseq mangling DynamoRIO/dynamorio
1 participant
@derekbruening