Optimization flags are removed for all tests #6429
Comments
philramsey-arm
added a commit
that referenced
this issue
Nov 9, 2023
Build most core tests with SVE flags and high optimisation (-O3), if building on an AARCH64 SVE machine. Tests which fail when built with -O3 are not included. Add some error checking to a few tests to allow the -O3 build and update template (expected output) files as necessary. Issue #6429 raised to cover making the removal of optimization flags more granular. Issue: #5365
philramsey-arm
added a commit
that referenced
this issue
Nov 9, 2023
Build most core tests with SVE flags and high optimisation (-O3), if building on an AARCH64 SVE machine. Tests which fail when built with -O3 are not included. Add some error checking to a few tests to allow the -O3 build and update template (expected output) files as necessary. Issue #6429 raised to cover making the removal of optimization flags more granular. Issue: #5365
philramsey-arm
added a commit
that referenced
this issue
Nov 9, 2023
Build most core tests with SVE flags and high optimisation (-O3), if building on an AARCH64 SVE machine. Tests which fail when built with -O3 are not included. Add some error checking to a few tests to allow the -O3 build and update template (expected output) files as necessary. Issue #6429 raised to cover making the removal of optimization flags more granular. Issue: #5365
philramsey-arm
added a commit
that referenced
this issue
Nov 10, 2023
Build most core tests with SVE flags and high optimisation (-O3), if building on an AARCH64 SVE machine. Tests which fail when built with -O3 are not included. Add some error checking to a few tests to allow the -O3 build and update template (expected output) files as necessary. Issue #6429 raised to cover making the removal of optimization flags more granular. Issue: #5365
philramsey-arm
added a commit
that referenced
this issue
Nov 10, 2023
Build most core tests with SVE flags and high optimisation (-O3), if building on a AARCH64 SVE machine. Tests which fail when built with -O3 are not included. Add some error checking to a few tests to allow the -O3 build and update template (expected output) files as necessary. Issue #6429 raised to cover making the removal of optimization flags more granular. Issue: #5365
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
CMakeLists.txtinsuite/testshas the linestring(REGEX REPLACE "-O[0-9]? " " " CMAKE_C_FLAGS "${CMAKE_C_FLAGS}")which strips out any optimization flags for the tests. Optimization is then selectively added later, using the
optimize()oradd_sve_flags()functions.A better approach would be to allow optimization by default, and strip optimization flags from those tests that cannot support them. This was investigated and proved to be non-trivial as the client tests use
_DR_set_compile_flags()to set the compile flags whereas the core tests useset_cflags()._DR_set_compile_flags()is a public function and we didn't want to add a blocklist in there.This issue covers the work to remove the blanket removal of optimization flags and find a way to strip optimization flags from tests that cannot support them, both for core and client tests.
The text was updated successfully, but these errors were encountered: