i#5365: Build core unit tests with SVE enabled #6371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add BUILD_TESTS_SVE build option to compile with SVE flags and high optimisation (-O3). Add some error checking to allow the -O3 build and consequently update a template (expected output) file. Issue: #5365
|
@derekbruening I'm happy to approve this change. Is there anything you would like to call out? |
Add BUILD_TESTS_SVE build option to compile with SVE flags and high optimisation (-O3). Add some error checking to allow the -O3 build and consequently update a template (expected output) file. Issue: #5365
Build most core tests with SVE flags and high optimisation (-O3), if building on a AARCH64 SVE machine. Tests which fail when built with -O3 are not included. Add some error checking to a few tests to allow the -O3 build and update template (expected output) files as necessary.
philramsey-arm
changed the title
derekbruening
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
Mostly requesting adding a bunch of comments so future readers (probably ourselves after we forget the details) can more easily understand the combination of removing -O* and re-instating it in two different places (optimize() and now add_sve_flags()) that we have now.
Build most core tests with SVE flags and high optimisation (-O3), if building on a AARCH64 SVE machine. Tests which fail when built with -O3 are not included. Add some error checking to a few tests to allow the -O3 build and update template (expected output) files as necessary. Issue: #5365
…O/dynamorio into sve
derekbruening
approved these changes
Nov 8, 2023
Build most core tests with SVE flags and high optimisation (-O3), if building on an AARCH64 SVE machine. Tests which fail when built with -O3 are not included. Add some error checking to a few tests to allow the -O3 build and update template (expected output) files as necessary. Issue #6429 raised to cover making the removal of optimization flags more granular. Issue: #5365
Build most core tests with SVE flags and high optimisation (-O3), if building on an AARCH64 SVE machine. Tests which fail when built with -O3 are not included. Add some error checking to a few tests to allow the -O3 build and update template (expected output) files as necessary. Issue #6429 raised to cover making the removal of optimization flags more granular. Issue: #5365
…O/dynamorio into sve
Build most core tests with SVE flags and high optimisation (-O3), if building on an AARCH64 SVE machine. Tests which fail when built with -O3 are not included. Add some error checking to a few tests to allow the -O3 build and update template (expected output) files as necessary. Issue #6429 raised to cover making the removal of optimization flags more granular. Issue: #5365
derekbruening
approved these changes
Nov 9, 2023
Build most core tests with SVE flags and high optimisation (-O3), if building on an AARCH64 SVE machine. Tests which fail when built with -O3 are not included. Add some error checking to a few tests to allow the -O3 build and update template (expected output) files as necessary. Issue #6429 raised to cover making the removal of optimization flags more granular. Issue: #5365
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build most core tests with SVE flags and high optimisation (-O3), if building on a AARCH64 SVE machine.
Tests which fail when built with -O3 are not included.
Add some error checking to a few tests to allow the -O3 build and update template (expected output) files as necessary.
Issue #6429 raised to cover making the removal of optimization flags more granular.
Issue: #5365