Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ISA mode from instr_t flags to its own dr_isa_mode_t field in instr_t #6698

Closed
edeiana opened this issue Mar 8, 2024 · 0 comments · Fixed by #6699
Closed

Move ISA mode from instr_t flags to its own dr_isa_mode_t field in instr_t #6698

edeiana opened this issue Mar 8, 2024 · 0 comments · Fixed by #6699
Assignees
@edeiana
Labels
Component-IR

Comments

@edeiana
Copy link
Contributor

edeiana commented Mar 8, 2024

This issue aims to bring us one step closer to full dynamic ISA selection in DynamoRio (xref #1684 #1595 #6690).
As of now the "flags" field in instr_t holds ISA mode information for instruction encoding.
We want to move such information into a new field of instr_t "dr_isa_mode_t isa_mode;" and update the setter and getter functions for instruction ISA mode accordingly.
This change increases the size of instr_t, but it also frees some bits in "flags" that can now be used for something else (note: all 4 bytes of "flags" were used, so we could use the space).
@edeiana edeiana self-assigned this Mar 8, 2024
edeiana added a commit that referenced this issue Mar 8, 2024
@edeiana
i#6698 instr_t ISA mode: move from flags to its own field
c4b9371 
Moves instruction-related ISA mode from instr_t flags field
to a new dr_isa_mode_t field in instr_t and updates setter
and getter functions for instr_t ISA mode.

Fixes #6698
This was referenced Mar 8, 2024
Merged
Open
edeiana added a commit that referenced this issue Mar 12, 2024
@edeiana
i#6698 instr_t ISA mode: move from flags to its own field (#6699)
2d2cd90 
Moves instruction-related ISA mode from instr_t flags field to a new
dr_isa_mode_t field in instr_t and updates setter and getter functions
for instr_t ISA mode.

Fixes #6698
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edeiana edeiana

Labels
Component-IR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

i#6698 instr_t ISA mode: move from flags to its own field DynamoRIO/dynamorio
1 participant
@edeiana