i#6698 instr_t ISA mode: move from flags to its own field #6699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves instruction-related ISA mode from instr_t flags field to a new dr_isa_mode_t field in instr_t and updates setter and getter functions for instr_t ISA mode. Fixes #6698
edeiana
commented
Mar 8, 2024
edeiana
commented
Mar 8, 2024
edeiana
commented
Mar 8, 2024
edeiana
commented
Mar 8, 2024
edeiana
commented
Mar 8, 2024
edeiana
commented
Mar 8, 2024
|
Lots of tests are currently failing. |
Added cast from byte to dr_isa_mode_t in instr_get_isa_mode() when necessary.
|
Thank you for the early review Derek! |
Moved instr_get_isa_mode() to instr_shared.c now that they all look the same.
We don't want to "expose" internal fields of instr_t.
for all arches, including x86.
derekbruening
approved these changes
Mar 12, 2024
|
code_api|tool.drcacheoff.windows-timestamps failed once (#6081) now passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves instruction-related ISA mode from instr_t flags field to a new dr_isa_mode_t field in instr_t and updates setter and getter functions for instr_t ISA mode.
Fixes #6698