i#6575: dr_{get,set}_sve_vector_length missing export specifiers #6576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr_set_sve_vector_length() and dr_get_sve_vector_length() in encode_api.h were are missing DR_API specifiers and thus were not exported from libdynamorio, causing link errors. Adds a test to ir_aarch64.c which fails without the fix. However, the test may fail on actual SVE hardware: updating it is future work, maybe by changing dr_set_sve_vector_length() to return a bool. Also tested on the same internal build where the failure was observed. Issue: #6575
|
x64 failure is client.detach #6536 |
ivankyluk
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dr_set_sve_vector_length() and dr_get_sve_vector_length() in encode_api.h were missing DR_API specifiers and thus were not exported from libdynamorio, causing link errors.
Adds a test to ir_aarch64.c which fails without the fix. However, the test may fail on actual SVE hardware: updating it is future work, maybe by changing dr_set_sve_vector_length() to return a bool.
Also tested on the same internal build where the failure was observed.
Issue: #6575