Support Rails 5.2 #256
Support Rails 5.2 #256
Conversation
| @@ -5,7 +5,7 @@ module Dirty | |||
|
|
|||
| module ClassMethods | |||
| def from_database(*) | |||
| super.tap { |d| d.changed_attributes.clear } | |||
| super.tap { |d| d.send(:clear_changes_information) } | |||
There was a problem hiding this comment.
Probably need to have it handle both versions since older versions of rails I don't think will support this so maybe:
d.respond_to?(:clear_changes_information) ? d.clear_changes_information : d.changed_attributes.clear
And similar to below to handle both
|
@richardhsu I would consider independent implementation of changes tracking. Depending on Rails internals makes me sad. |
|
@andrykonchin Yeah makes sense, and yeah their internals are changing so much now. I've run a few tests with this update and looking good so far. Going to run full suite tomorrow and make sure those pass. |
|
I'm running this in production, so far no issues. |
|
@pboling I would like to release new version 2.1.1 with this bug fix only. Does it make sense? |
|
@andrykonchin do it! |
|
As for depending on Rails internals, I think making this gem a standalone ORM that can be used with other frameworks would be great. Might as well make that a target goal of a future release. |
This was a tough one to diagnose. The Dirty module introduced the usage of an attribute mutation tracker, being disabled here for functional tests to start working again. This commit is based on: Dynamoid/dynamoid#256 Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Related issue #254