Add store_boolean_as_native global config option #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrykonchin
changed the title
andrykonchin
force-pushed
the
add-store-boolean-as-native-config-option
branch
from
abd5830
to
fdff404
Compare
pboling
approved these changes
Aug 15, 2018
lib/dynamoid/undumping.rb
Outdated
| end | ||
| if store_as_boolean | ||
| !!value | ||
| elsif ['t', 'f'].include?(value) |
There was a problem hiding this comment.
Would like to make this array a constant within the class. No need to instantiate again on every call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option is similar to the
store_as_native_booleanfield option and means the same.By default the option is true so any boolean field will be stored as native DynamoDB's boolean value.