Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add #update_attributes! method #303

Merged
merged 4 commits into from Oct 4, 2018
Merged

Add #update_attributes! method #303

merged 4 commits into from Oct 4, 2018

Conversation

andrykonchin
Copy link
Member

Updates:

  • added #update_attributes! method
  • added some basic specs for #update_attributes method

There was only #update_attributes method (without bang) so it's confusing not to have the complementary method with bang.

pboling
pboling approved these changes Oct 4, 2018
View reviewed changes
Copy link
Member

@pboling pboling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent.

@andrykonchin andrykonchin merged commit 9b1767a into master Oct 4, 2018
@andrykonchin andrykonchin deleted the add-update-attributes-with-bang branch October 4, 2018 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pboling pboling pboling approved these changes

@richardhsu richardhsu Awaiting requested review from richardhsu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andrykonchin @pboling