Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some methods in Dirty module public #627

Merged
merged 3 commits into from Jan 14, 2023

Conversation

andrykonchin
Copy link
Member

Make the following existing Dirty methods public:

  • clear_changes_information
  • changes_applied
  • clear_attribute_changes

These methods are public in Rails' ActiveModel - https://api.rubyonrails.org/classes/ActiveModel/Dirty.html

@andrykonchin andrykonchin force-pushed the make-some-methods-in-dirty-module-public branch from 7e8b57b to 5257766 Compare January 13, 2023 11:10
@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Merging #627 (a5705a1) into master (13ee680) will decrease coverage by 0.00%.
The diff coverage is 97.50%.

❗ Current head a5705a1 differs from pull request most recent head 3ab00ba. Consider uploading reports for the commit 3ab00ba to get more accurate results

@@            Coverage Diff             @@
##           master     #627      +/-   ##
==========================================
- Coverage   90.17%   90.17%   -0.01%     
==========================================
  Files          60       60              
  Lines        3054     3053       -1     
==========================================
- Hits         2754     2753       -1     
  Misses        300      300              
Impacted Files Coverage Δ
lib/dynamoid/dirty.rb 96.38% <97.50%> (-0.05%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@andrykonchin andrykonchin force-pushed the make-some-methods-in-dirty-module-public branch from 5257766 to da97dac Compare January 13, 2023 11:20
@andrykonchin andrykonchin force-pushed the make-some-methods-in-dirty-module-public branch from da97dac to 3ab00ba Compare January 13, 2023 11:25
@github-actions
Copy link

Code Coverage

Package Line Rate Health
dynamoid 90%
Summary 90% (2753 / 3053)

Minimum allowed line rate is 90%

@andrykonchin andrykonchin merged commit 77f956b into master Jan 14, 2023
@andrykonchin andrykonchin deleted the make-some-methods-in-dirty-module-public branch January 14, 2023 09:53
@andrykonchin andrykonchin added this to the v3.9.0 milestone Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant