This repository has been archived by the owner on Dec 11, 2023. It is now read-only.
Use node affinity to schedule pods on supported platforms #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubernetes 1.18+ is expected to drop the "beta.kubernetes.io" labels, https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.14.md#deprecations This is in favor of "kubernetes.io" which was added on 1.14. This commit replaces the node selectors using the old labels with node affinity for more flexibility.
DTMad
approved these changes
Feb 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
beta.kubernetes.io/archandbeta.kubernetes.io/oslabels have been deprecated, andkubernetes.io-named labels, added on Kubernetes 1.14, are now recommended instead.This PR replaces the node selectors using the old labels with node affinity for more flexibility so that we can handle both old and new Kubernetes versions, once the beta-labels are removed (Kubernetes 1.18, supposedly.)
Technically, this is a breaking change, since customers can't now use a
beta.kubernetes.io/osvalue other thanlinuxsince the affinity is not currently customizable on the CR. Although, is this an actual use case?Either way, we should support custom affinities on the CR, but I'll leave it for a later PR.