Path stripping #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yazgazan
reviewed
Apr 26, 2017
main.go
Outdated
| @@ -86,18 +82,33 @@ func main() { | |||
| s.ListenAndServe() | |||
| } | |||
|
|
|||
| func newProxy(backend *url.URL, l log.Logger) *httputil.ReverseProxy { | |||
There was a problem hiding this comment.
I personally prefer having the loggers, db and such as first arguments. Not sure what the convention is (if there is any).
Also, some of your functions get the logger first (NewAllowedActions for example). So consistency could be nice :)
yazgazan
reviewed
Apr 26, 2017
main.go
Outdated
| proxy := httputil.NewSingleHostReverseProxy(backend) | ||
| proxy.ErrorLog = stdlog.New(log.NewStdlibAdapter(l), "", stdlog.LstdFlags) | ||
| proxy.Transport = &http.Transport{ | ||
| DisableCompression: true, |
There was a problem hiding this comment.
I'm curious, why disable compression ?
There was a problem hiding this comment.
It makes little sense for binary, is all.
yazgazan
reviewed
Apr 26, 2017
main.go
Outdated
|
|
||
| s := &http.Server{ | ||
| Addr: fmt.Sprintf(":%d", listenPort), | ||
| Handler: decorateHandler(proxy, rlBucket), | ||
| Handler: decorateHandler(proxy, rlBucket, logger), |
There was a problem hiding this comment.
decorateHandler could accept logger in first position too
main.go
Outdated
| // Defining early needed handlers last | ||
| decorators = append( | ||
| decorators, | ||
| handlers.NewIgnoreFaviconRequests(), | ||
| handlers.NewRateLimitHandler(b, logger), | ||
| handlers.NewRateLimitHandler(b, l), |
There was a problem hiding this comment.
Could accept logger first as well
yazgazan
approved these changes
Apr 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature allows you to strip a part of the path being sent to Imaginary.
An example:
With:
Sents the path
/enlargeto Imaginary, instead of/static/enlargeThis is useful when dealing with (e.g.) GKE's L7 firewalls