Update TOP solar radiation parameterization #6467
Conversation
…titude limit fix a small bug
|
Does this change answers? |
No. It will affect the simulations only when TOP is turned on by use_top_solar_rad = .true.. |
|
But isn't TOP on by default? Its used in v3. |
|
It is just turned on in the water cycle simulations. It is off in the
master branch.
Robert Jacob ***@***.***> 于2024年6月12日周三 13:02写道：
… But isn't TOP on by default? Its used in v3.
—
Reply to this email directly, view it on GitHub
<#6467 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMSGUOSYFPSW4US3DDUXKPTZHCSPDAVCNFSM6AAAAABJGT3B4GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRTHAYDINBTHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
No it is on in the master branch. Our policy is that the v3.0 tag should make v3.0 answers without relying on a runscript. See #6108. |
| @@ -1811,7 +1811,7 @@ subroutine Albedo_TOP_Adjustment(bounds, num_pft, filter_pft, & | |||
| lon_180 = lon(g) | |||
| if (lon_180 > pi) lon_180 = lon_180-2._r8*pi | |||
|
|
|||
| if (cosz > 0._r8 .and. abs(lat(g)) < 1.047_r8 .and. stdev_elev(g) > 0._r8) then | |||
There was a problem hiding this comment.
@daleihao, As we discussed offline, please undo this change.
There was a problem hiding this comment.
Forgot to mention that once you revert this code change, please update the first comment msg. Thanks.
After undoing one change, the code will not change the answers. |
|
discussion: this makes sure TOP works for grids not used in WCYCLE v3. |
|
@bishtgautam please re-review. |
1 similar comment
|
@bishtgautam please re-review. |
|
@bishtgautam can this be merged? |
|
I will merge this today. |
Minor modification for TOP solar radiation parameterization: Use `STD_ELEV` std_elev when `STDEV_ELEV` is not available in fsurdata. [BFB]
Minor modification for TOP solar radiation parameterization:
Use
STD_ELEVstd_elev whenSTDEV_ELEVis not available in fsurdata.[BFB]