-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable E3SM shared pi in MPAS-Ocean #6485
base: master
Are you sure you want to change the base?
Conversation
Does this change answers for coupled cases? |
Would you like me to close this PR and reopen at a later date? |
Leave it open. We'll be making the maint-3.0 branch soon and this can go in after that. |
Great, thanks, @rljacob! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still many places in both shared
and analysis_members
that use pii
from the MPAS framework. These should also be updated to use MPAS-Ocean's pi
instead. See include:
https://github.com/search?q=repo%3AE3SM-Project%2FE3SM+pii+path%3A%2F%5Ecomponents%5C%2Fmpas-ocean%5C%2F%2F&type=code
This was taken care of for global ocean init mode in #6481
Thanks for pointing this out! I didn't think to grep for that spelling. I'll make those changes as well. |
We are planning a separate PR for sea ice. |
Great. I'll confine this PR to only the ocean component then. |
cf5ead7
to
83c5a22
Compare
Co-authored-by: Xylar Asay-Davis <xylarstorm@gmail.com>
83c5a22
to
b3c8342
Compare
This PR enables the use of E3SM shared constant pi in MPAS-Ocean when run in coupled configurations.