Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable E3SM shared pi in MPAS-Ocean #6485

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

cbegeman
Copy link
Contributor

This PR enables the use of E3SM shared constant pi in MPAS-Ocean when run in coupled configurations.

@cbegeman cbegeman requested a review from xylar June 24, 2024 16:49
@cbegeman
Copy link
Contributor Author

@xylar In addition to your #6481, do we want to include the changes I have here as a separate PR?

@rljacob
Copy link
Member

rljacob commented Jun 26, 2024

Does this change answers for coupled cases?

@xylar
Copy link
Contributor

xylar commented Jun 27, 2024

@rljacob, I think these will be answer changing for all runs involving MPAS-Ocean, including coupled runs.

@cbegeman, that is why I had not opted to make these changes yet, though I think they are very desirable.

@xylar xylar added the non-BFB PR makes roundoff changes to answers. label Jun 27, 2024
@cbegeman
Copy link
Contributor Author

Would you like me to close this PR and reopen at a later date?

@xylar
Copy link
Contributor

xylar commented Jun 27, 2024

@cbegeman. let's see what @rljacob says.

@rljacob
Copy link
Member

rljacob commented Jun 27, 2024

Leave it open. We'll be making the maint-3.0 branch soon and this can go in after that.

@rljacob rljacob added this to the v3.1beta milestone Jun 27, 2024
@xylar
Copy link
Contributor

xylar commented Jun 27, 2024

Great, thanks, @rljacob!

@cbegeman
Copy link
Contributor Author

Thanks, @rljacob and @xylar for your feedback

Copy link
Contributor

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still many places in both shared and analysis_members that use pii from the MPAS framework. These should also be updated to use MPAS-Ocean's pi instead. See include:
https://github.com/search?q=repo%3AE3SM-Project%2FE3SM+pii+path%3A%2F%5Ecomponents%5C%2Fmpas-ocean%5C%2F%2F&type=code

This was taken care of for global ocean init mode in #6481

components/mpas-ocean/src/shared/mpas_ocn_constants.F Outdated Show resolved Hide resolved
@cbegeman
Copy link
Contributor Author

cbegeman commented Jul 1, 2024

There are still many places in both shared and analysis_members that use pii from the MPAS framework.

Thanks for pointing this out! I didn't think to grep for that spelling. I'll make those changes as well.

@proteanplanet
Copy link
Contributor

We are planning a separate PR for sea ice.

@cbegeman
Copy link
Contributor Author

cbegeman commented Jul 1, 2024

We are planning a separate PR for sea ice.

Great. I'll confine this PR to only the ocean component then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mpas-ocean non-BFB PR makes roundoff changes to answers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants