Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixed phase partition LCF diagram #675

Merged
merged 15 commits into from
Jun 6, 2023
Merged

Conversation

chengzhuzhang
Copy link
Contributor

@chengzhuzhang chengzhuzhang commented Feb 23, 2023

New feature requested by #653

  • Include pre-processing (add CLDLIQ and CLDICE to monthly variable list)
  • Add standalone script (TODO add benchmarking data using v1 and v2)
  • Add new driver including plotting script, parameter, parser, viewer

@chengzhuzhang chengzhuzhang marked this pull request as ready for review May 1, 2023 18:09
@chengzhuzhang
Copy link
Contributor Author

@zyuying and @susburrows I have implemented codes for the T5050 diagram, here is the link to the example figure. The unresolved part is the variable change for CLDICE from v2 to v3 P3. I will update this PR as soon as the new variable name/convention is decided on.

@susburrows
Copy link
Contributor

This looks great! It will be great to have this diagnostic available in e3sm_diags so we can easily check on global cloud phase partitioning during model development.

@chengzhuzhang
Copy link
Contributor Author

@zyuying I was wondering is there an update on the variables to be used for this diagnostics? I'm hoping to have this branch finalized and merged by the end of this month for a new e3sm_diags release.

@chengzhuzhang
Copy link
Contributor Author

Based on a discussion with @zyuying , this PR can be merged to prepare for joining the e3sm-unified release. There will be a separate PR to add simulator comparison and to accommodate v3 output.

@chengzhuzhang chengzhuzhang merged commit 39ccc4a into main Jun 6, 2023
4 checks passed
@chengzhuzhang chengzhuzhang deleted the mixed-phase_partition branch June 6, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants