Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default diagnostics attrs not being copied to parent CoreParameter #778

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

tomvothecoder
Copy link
Collaborator

@tomvothecoder tomvothecoder commented Jan 8, 2024

Description

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

If applicable:

  • New and existing unit tests pass with my changes (locally and CI/CD build)
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

@tomvothecoder tomvothecoder self-assigned this Jan 8, 2024
@tomvothecoder tomvothecoder added the bug Bug fix (will increment patch version) label Jan 8, 2024
@tomvothecoder tomvothecoder marked this pull request as ready for review January 8, 2024 21:07
@tomvothecoder tomvothecoder merged commit 3e49671 into main Jan 8, 2024
4 checks passed
@tomvothecoder tomvothecoder deleted the bugfix/777-copy-attrs branch January 8, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug fix (will increment patch version)
Projects
None yet
1 participant