Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perlmutter support #227

Merged
merged 1 commit into from
Nov 1, 2022
Merged

Perlmutter support #227

merged 1 commit into from
Nov 1, 2022

Conversation

forsyth2
Copy link
Collaborator

@forsyth2 forsyth2 commented Oct 27, 2022 •
edited
Loading

Perlmutter support. Resolves part of #223.

@forsyth2 forsyth2 added the priority: high High priority task label Oct 27, 2022
@forsyth2 forsyth2 self-assigned this Oct 27, 2022
@forsyth2 forsyth2 marked this pull request as draft October 27, 2022 23:46
forsyth2
forsyth2 commented Oct 28, 2022
View reviewed changes
tests/test_globus.py Outdated
Comment on lines 20 to 21
r"perlmutter.*\.nersc\.gov": "9d6d99eb-6d04-11e5-ba46-22000b92c6ec",
# r"perlmutter.*\.nersc\.gov" : "63e2f6ac-a46f-4853-b518-e6e33859e860"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lukaszlacinski I can't get test_globus working on Perlmutter. I don't see an "Activate" button on https://app.globus.org/file-manager/collections/6bdc7956-fc0f-4ad2-989c-7aa5ee643a79/overview as I do on https://app.globus.org/file-manager/collections/61f9954c-a4fa-11ea-8f07-0a21f750d19b/overview for example.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also fails if I set r"perlmutter.*\.nersc\.gov": "6bdc7956-fc0f-4ad2-989c-7aa5ee643a79"

@forsyth2
Copy link
Collaborator Author

I had to use --no-verify on commits because I'm running into AttributeError: 'EntryPoints' object has no attribute 'get'. This error was seen in E3SM-Project/zppy#318 (comment), which suggests we need something like E3SM-Project/zppy#321. That is, #224 was not a sufficient update.

@forsyth2 forsyth2 mentioned this pull request Oct 28, 2022
Merged
@forsyth2
Copy link
Collaborator Author

I had to use --no-verify on commits

Resolved with #228.

@forsyth2 forsyth2 added the semver: incompatible API change Incompatible API change (will increment major version) label Nov 1, 2022
@forsyth2 forsyth2 removed the semver: incompatible API change Incompatible API change (will increment major version) label Nov 1, 2022
@forsyth2 forsyth2 mentioned this pull request Nov 1, 2022
Closed
@forsyth2 forsyth2 marked this pull request as ready for review November 1, 2022 13:06
@forsyth2
Copy link
Collaborator Author

forsyth2 commented Nov 1, 2022

On Cori, all 64 tests pass. On Perlmutter, all pass except the Globus test, which gets skipped. Keeping #223 open to eventually fully replace Cori with Perlmutter.

@forsyth2 forsyth2 merged commit a6667f7 into main Nov 1, 2022
@forsyth2 forsyth2 deleted the perlmutter branch November 1, 2022 13:08
@forsyth2 forsyth2 added semver: new feature New feature (will increment minor version) Documentation Files in `docs` modified and removed semver: new feature New feature (will increment minor version) labels Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@forsyth2 forsyth2

Labels
Documentation Files in `docs` modified priority: high High priority task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@forsyth2