Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Push built containers to registry #38

Merged
merged 10 commits into from
Sep 26, 2023
Merged

Push built containers to registry #38

merged 10 commits into from
Sep 26, 2023

Conversation

SandyRogers
Copy link
Member

This PR:

  • switches the deployment process from trigger-based (builds happen on Quay.io) to push-based (builds happen on GitHub Actions)
    • this is due to better performance on GHA runners, and to save building twice (once on GH for testing, once on Quay for rollout)

@SandyRogers SandyRogers merged commit ee18e8f into main Sep 26, 2023
1 of 2 checks passed
@SandyRogers SandyRogers deleted the quay-push branch September 26, 2023 16:42
SHillman836 pushed a commit to SHillman836/notebooks that referenced this pull request Jul 10, 2024
@SandyRogers @KateSakharova
Push built containers to registry (EBI-Metagenomics#38)
66d2608 
* atlanteco notebook

* fixing leafmap rendering

* rename and clean notebook

* adds workflow step to push built image to quay.io

* fix actions var scope

* switch to docker provided action

* different format of github ref name

* push using docker cli instead of build-push action

* adds release workflow

---------

Co-authored-by: Ekaterina Sakharova <kates@ebi.ac.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SandyRogers @KateSakharova