Fix/update atlanteco #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
KateSakharova
commented
Mar 19, 2024
KateSakharova
commented
- Fixed usage of first pop up studies to one particular study for proper example
- Add IPS entries
- Add BGC check
SandyRogers
requested changes
Mar 21, 2024
There was a problem hiding this comment.
Thanks @KateSakharova !! Looks great. Two tiny things before merging, could you please:
- do "clear all outputs" in the notebook
- remove the execution : false stuff from the metadata in the first raw cell at top of notebook (this will make sure the notebook actually builds into the docs site – I added that before since the build was failing)
Later on... as you suggested I will make some other notebook or util for the RO Crate ingestion, and then we can use that here.
SandyRogers
approved these changes
Apr 11, 2024
SHillman836
pushed a commit
to SHillman836/notebooks
that referenced
this pull request
Jul 10, 2024
* wip * added IPS check * add BGC * fixes after review * Clear outputs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.