EVA-486 PopulationStatistics: add chr, start, ref, alt fields #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyenyxe
reviewed
Nov 30, 2016
| @@ -101,9 +101,10 @@ public void shouldCreateIndexesInCollection() throws Exception { | |||
|
|
|||
| // check vid has an index | |||
There was a problem hiding this comment.
This comments need to be updated to reflect the new structure.
There was a problem hiding this comment.
forgot about this PR, fixed in next commit
cyenyxe
changed the title
jmmut
force-pushed
the
feature/population-stats
branch
from
dda81aa
to
159d29f
Compare
This was necessary if we want to do better queries like going
to a specific region. this would we harder if we had only the
merged vid. {vid: {$lte: 20_7000}} would not only query the
positions before 7000, but all the previous chromosomes as well.
jmmut
force-pushed
the
feature/population-stats
branch
from
159d29f
to
611514b
Compare
cyenyxe
suggested changes
Dec 6, 2016
| ".populationStatistics\"}, { \"v\" : 1 , \"unique\" : true , \"key\" : " + | ||
| "{ \"chr\" : 1 , \"start\" : 1 , \"ref\" : 1 , \"alt\" : 1 , \"sid\" : 1 , \"cid\" : 1} , " + | ||
| "\"name\" : \"vscid\" , \"ns\" : \"" + databaseName + ".populationStatistics\"}]", | ||
| statsCollection.getIndexInfo().toString()); |
There was a problem hiding this comment.
This test could compare the DBObjects extracted from getIndexInfo() using the equals() method.
cyenyxe
approved these changes
Dec 6, 2016
cyenyxe
pushed a commit
that referenced
this pull request
Dec 6, 2016
EVA-486 PopulationStatistics: add chr, start, ref, alt fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was necessary if we want to do better queries like going
to a specific region. this would we harder if we had only the
merged vid. {vid: {$lte: 20_7000}} would not only query the
positions before 7000, but all the previous chromosomes as well.