Study ws server v2 #126
Merged
Study ws server v2 #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junaidnz97
force-pushed
the
ArchiveWSServerV2
branch
from
45c90d5
to
03e943e
Compare
jmmut
requested changes
Aug 9, 2019
| private ObjectMapper objectMapper; | ||
|
|
||
| @Before | ||
| public void setUp() throws Exception { |
There was a problem hiding this comment.
no need to keep this if it's empty
|
|
||
| @RequestMapping(value = "/", method = RequestMethod.GET) | ||
| public ResponseEntity getBrowsableStudies(@RequestParam("species") String species, | ||
| @RequestParam("assembly") String assembly, |
There was a problem hiding this comment.
you can either copy the descriptions for these fields from #127 or add them here, whatever you prefer
jmmut
requested changes
Aug 9, 2019
eva-server/src/main/java/uk/ac/ebi/eva/server/ws/StudyWSServerV2.java
Outdated
Show resolved
Hide resolved
jmmut
approved these changes
Aug 9, 2019
andresfsilva
requested changes
Aug 9, 2019
eva-server/src/main/java/uk/ac/ebi/eva/server/ws/StudyWSServerV2.java
Outdated
Show resolved
Hide resolved
eva-server/src/main/java/uk/ac/ebi/eva/server/ws/StudyWSServerV2.java
Outdated
Show resolved
Hide resolved
eva-server/src/main/java/uk/ac/ebi/eva/server/ws/StudyWSServerV2.java
Outdated
Show resolved
Hide resolved
eva-server/src/test/java/uk/ac/ebi/eva/server/ws/StudyWSServerV2Test.java
Outdated
Show resolved
Hide resolved
| .read("$['page']['number']", Integer.class); | ||
| Integer size = JsonPath.using(configuration).parse(response.getBody()) | ||
| .read("$['page']['size']", Integer.class); | ||
| Integer totalPages = JsonPath.using(configuration).parse(response.getBody()) |
There was a problem hiding this comment.
totalPages is not being used, can you add the validation for it?
andresfsilva
approved these changes
Aug 12, 2019
junaidnz97
force-pushed
the
ArchiveWSServerV2
branch
from
be152ab
to
7e201bd
Compare
…V2.java Co-Authored-By: jmmut <jomutlo@gmail.com>
Co-Authored-By: andresfsilva <afsilva04@gmail.com>
junaidnz97
force-pushed
the
ArchiveWSServerV2
branch
from
7e201bd
to
3c5d27f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to add a the V2 endpoint for ArchiveWSServer