Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVA-3330: Add labels to nextflow for SLURM migration #40

Merged
merged 10 commits into from
Jun 14, 2024

Conversation

apriltuesday
Copy link
Contributor

No description provided.

maxRetries 3
// Memory required is 10 times the size of the fasta in Bytes or at least 2GB
// Overwrite base_memory so that the standard retry strategy is used
ext base_memory: { Math.max(file(params.newgenome).size() * 10, 2000000000) }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now working with updated configs, see run on Seqera

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good but I'm wondering how anyone else that does not have our nextflow config would use this.
We could add some default nextflow config to the repo or add to the documentation how the memory requirement should be managed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is a good point, a config placed alongside the pipelines would (I think) take precedence over the one in the home directory which I'm not sure is a good idea for us. But including an example config somewhere and documenting the usage is definitely a good idea.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added, here

@apriltuesday apriltuesday marked this pull request as ready for review June 12, 2024 12:42
@apriltuesday apriltuesday self-assigned this Jun 12, 2024
maxRetries 3
// Memory required is 10 times the size of the fasta in Bytes or at least 2GB
// Overwrite base_memory so that the standard retry strategy is used
ext base_memory: { Math.max(file(params.newgenome).size() * 10, 2000000000) }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good but I'm wondering how anyone else that does not have our nextflow config would use this.
We could add some default nextflow config to the repo or add to the documentation how the memory requirement should be managed.

@tcezard
Copy link
Member

tcezard commented Jun 14, 2024

Looks good to me

@apriltuesday apriltuesday merged commit 2091345 into EBIvariation:master Jun 14, 2024
1 check passed
@apriltuesday apriltuesday deleted the EVA-3330 branch June 14, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants