Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces sass-rails with sassc-rails due to gem deprecation. #3129

Merged
merged 1 commit into from Aug 13, 2019

Conversation

rlgreen91
Copy link
Contributor

@rlgreen91 rlgreen91 commented Aug 10, 2019

This change will replace the sass-rails gem with the sassc-rails gem. As noted here, the original Ruby implementation of Sass has been deprecated and EOL was in March. The sass-rails gem is supposed to get an upgrade to sassc, but it's unclear when that will happen, so the change to the gem was made. The only other gem we have that depends on sass-rails is rails_admin, but based on this it's unclear when or if that change will occur.

Edit: Actually, it should be noted that rails_admin has been updated to use sassc-rails as part of 2.0.0.rc - as such, we will wait for the official release of version 2 before upgrading that gem.

In your PR did you:

  • Include a description of the changes?
  • Mention the issue the PR addresses?
  • Include screenshots of any changes to the UI?
  • Isolate any changes to gems (meaning that any new, updated, or removed gems and resulting code changes should be in their own PR)?
  • Add and/or update specs for your code?

Copy link
Contributor

@trystant trystant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rlgreen91 rlgreen91 merged commit 5ee0f32 into master Aug 13, 2019
@rlgreen91 rlgreen91 deleted the move_to_sassc_rails_gem branch August 13, 2019 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants