New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to sassc-rails as Ruby Sass is deprecated #3072
Switch to sassc-rails as Ruby Sass is deprecated #3072
Conversation
https://github.com/sass/ruby-sass Ruby Sass is deprecated and will be unmaintained as of 26 March 2019. This switches the sass-rails over to sassc-rails.
CI appears to be breaking after I branched off master 😯 Anyone know how I can fix? @sferik |
any updates? |
@riouruma I'm also curious as to what I can do to help get this in :) |
@MikeRogers0 You should pull master. That resolves fatal errors of CI. |
Merged master & also updated the |
Some of errors may be resolved by below. Reason:
|
I'm struggling a bit with this :/ Anyone else want take over this PR? // @itoyama |
Hi, I'm a little confused by the changes of this PR. Looking at https://github.com/sferik/rails_admin/pull/3072/files, it seems like you are adding sassc-rails, but sass-rails is also still in there. I think that might be what's causing the conflicts in the CI? |
I think this has been fixed upstream rails/sass-rails#424 - I can close this PR off now. |
@MikeRogers0 - Think you can reopen this item again because sassc-rails gem appears to be a drop in replacement for sass-rails gem. FYI |
What is the status of this change? I know that sass-rails is supposed to be switching to sassc in version 6, but it's unclear when that upgrade will be coming and EOL was back in March. |
@rlgreen91 #3156 is in place now. |
https://github.com/sass/ruby-sass Ruby Sass is deprecated and will be unmaintained as of 26 March 2019.
This switches the
sass-rails
gem over tosassc-rails
( https://github.com/sass/sassc-rails ) .