Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to sassc-rails as Ruby Sass is deprecated #3072

Closed
wants to merge 9 commits into from
Closed

Switch to sassc-rails as Ruby Sass is deprecated #3072

wants to merge 9 commits into from

Conversation

MikeRogers0
Copy link
Contributor

https://github.com/sass/ruby-sass Ruby Sass is deprecated and will be unmaintained as of 26 March 2019.

This switches the sass-rails gem over to sassc-rails ( https://github.com/sass/sassc-rails ) .

https://github.com/sass/ruby-sass Ruby Sass is deprecated and will be unmaintained as of 26 March 2019.

This switches the sass-rails over to sassc-rails.
@MikeRogers0 MikeRogers0 changed the title Switch to SCSSC as Ruby Sass is deprecated Switch to sassc-rails as Ruby Sass is deprecated Sep 26, 2018
@MikeRogers0
Copy link
Contributor Author

CI appears to be breaking after I branched off master 😯 Anyone know how I can fix? @sferik

@riouruma
Copy link

any updates?

@MikeRogers0
Copy link
Contributor Author

@riouruma I'm also curious as to what I can do to help get this in :)

@itoyama
Copy link
Contributor

itoyama commented Feb 6, 2019

@MikeRogers0 You should pull master. That resolves fatal errors of CI.

@MikeRogers0
Copy link
Contributor Author

Merged master & also updated the Gemfile with include the new replacement gem. I'm still seeing failures :/

@itoyama
Copy link
Contributor

itoyama commented Feb 7, 2019

Some of errors may be resolved by below.
gem 'sqlite3', '>= 1.3' -> gem 'sqlite3', '~> 1.3.0' in Gemfile and all of gemfiles/rails_*.*.gemfile

Reason:
https://travis-ci.org/sferik/rails_admin/jobs/489587773#L661
https://rubygems.org/gems/sqlite3

1.4.0 - February 04, 2019 (68.5 KB)

@MikeRogers0
Copy link
Contributor Author

I'm struggling a bit with this :/ Anyone else want take over this PR? // @itoyama

@peret
Copy link

peret commented Mar 27, 2019

Hi, I'm a little confused by the changes of this PR. Looking at https://github.com/sferik/rails_admin/pull/3072/files, it seems like you are adding sassc-rails, but sass-rails is also still in there. I think that might be what's causing the conflicts in the CI?
Can you double-check your commits to make sure you are replacing the sass-rails gem?

@MikeRogers0
Copy link
Contributor Author

MikeRogers0 commented Mar 28, 2019

I think this has been fixed upstream rails/sass-rails#424 - I can close this PR off now.

@MikeRogers0 MikeRogers0 deleted the feature/move-to-sassc-rails branch March 28, 2019 11:30
@jasnow
Copy link

jasnow commented Jun 18, 2019

@MikeRogers0 - Think you can reopen this item again because sassc-rails gem appears to be a drop in replacement for sass-rails gem. FYI

@rlgreen91
Copy link

What is the status of this change? I know that sass-rails is supposed to be switching to sassc in version 6, but it's unclear when that upgrade will be coming and EOL was back in March.

@mshibuya
Copy link
Member

@rlgreen91 #3156 is in place now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants