MailTemplateRepository の member_id がベタ書き対応 #2027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chihiro-adachi
suggested changes
Jan 11, 2017
| @@ -34,20 +35,20 @@ | |||
| */ | |||
| class MailTemplateRepository extends EntityRepository | |||
| { | |||
| public function findOrCreate($id) | |||
| public function findOrCreate($id, $Creator = null) | |||
There was a problem hiding this comment.
@trebla-on
こちらの修正も、#2026 と同様かと思いますので、ご確認いただけますか。
#2026 (comment)
|
@chihiro-adachi 修正しました、ご確認お願いします。 |
chihiro-adachi
approved these changes
Jan 16, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MailTemplateRepository の member_id がベタ書き対応
#894
修正内容：
クラス｛MailTemplateRepository｝のメッソド｛findOrCreate｝変更しました。
Member引数で渡すようにしました、Member渡してなかった場合はいままでとおなじ自動的に取得する、ただベタ書きではなくって｛rankのASC｝レーコドを取得する