-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
マスタデーター管理で、エラーを表示するように修正 #2108
マスタデーター管理で、エラーを表示するように修正 #2108
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
コード確認しました。問題ないと思います。
@@ -3223,3 +3223,7 @@ textarea#log { | |||
#shipping_info__button_new { | |||
margin-bottom: 20px; | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please delete this source code.
@@ -89,10 +93,12 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. | |||
{% for data in form2.data %} | |||
<tr id="result_list__item--{{ data.vars.name }}"> | |||
<td id="result_list__id--{{ data.vars.name }}"> | |||
{{form_widget(data.id)}} | |||
{{form_widget(data.id)}} <br/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please delete <br/>
.
</td> | ||
<td id="result_list__name--{{ data.vars.name }}"> | ||
{{form_widget(data.name)}} | ||
{{form_widget(data.name)}} <br/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please delete <br/>
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ソースコード問題ありません。
動作確認も問題ありません。
|
エラーメッセージが黒色のままであるが、 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
問題ないと思います。
影響する機能が限定的なので、3.0.14に含める方向で進めます。
コミットログが多いので、まとめてコミットします。 * [FIX] Fix issue 1884 * [FIX] Fix as review. * [FIX] Change check condition. * [ADD] Add unit test for zero case. * [REMOVE] Remove app translate. * [REMOVE] Remove alert error of the master edit page. * [MOVE] Move css into dashboard.css * [REMOVE] Remove color for error text.
ref #1884
Fixed : マスタデーター管理の必須チェックエラーが表示されない