マスタデーター管理で、エラーを表示するように修正 #2108
Merged
マスタデーター管理で、エラーを表示するように修正 #2108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-nagahashi
reviewed
Feb 28, 2017
| @@ -3223,3 +3223,7 @@ textarea#log { | |||
| #shipping_info__button_new { | |||
| margin-bottom: 20px; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
please delete this source code.
t-nagahashi
reviewed
Feb 28, 2017
| @@ -89,10 +93,12 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. | |||
| {% for data in form2.data %} | |||
| <tr id="result_list__item--{{ data.vars.name }}"> | |||
| <td id="result_list__id--{{ data.vars.name }}"> | |||
| {{form_widget(data.id)}} | |||
| {{form_widget(data.id)}} <br/> | |||
t-nagahashi
reviewed
Feb 28, 2017
| </td> | ||
| <td id="result_list__name--{{ data.vars.name }}"> | ||
| {{form_widget(data.name)}} | ||
| {{form_widget(data.name)}} <br/> |
|
動作確認も問題ありません。
|
|
エラーメッセージが黒色のままであるが、 |
ryo-endo
approved these changes
Feb 28, 2017
Closed
ryo-endo
pushed a commit
to ryo-endo/ec-cube
that referenced
this pull request
Apr 3, 2017
コミットログが多いので、まとめてコミットします。 * [FIX] Fix issue 1884 * [FIX] Fix as review. * [FIX] Change check condition. * [ADD] Add unit test for zero case. * [REMOVE] Remove app translate. * [REMOVE] Remove alert error of the master edit page. * [MOVE] Move css into dashboard.css * [REMOVE] Remove color for error text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #1884
Fixed : マスタデーター管理の必須チェックエラーが表示されない