-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
住所や会員情報を国際標準へ対応 #2598 #3234
Merged
chihiro-adachi
merged 29 commits into
EC-CUBE:experimental/sf
from
eccubevn:sf-w27-zip-code-to-postal
Jun 28, 2018
Merged
住所や会員情報を国際標準へ対応 #2598 #3234
chihiro-adachi
merged 29 commits into
EC-CUBE:experimental/sf
from
eccubevn:sf-w27-zip-code-to-postal
Jun 28, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vn/ec-cube into sf-w27-zip-code-to-postal
…to sf-w27-zip-code-to-postal
…27-zip-code-to-postal
…vn/ec-cube into sf-w27-zip-code-to-postal
…27-zip-code-to-postal
chihiro-adachi
approved these changes
Jun 28, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要(Overview・Refs Issue)
受け入れ条件
電話番号(tel)のフィールドを1カラムにする
郵便番号(zip)のフィールドを1カラムにする
FAXは廃止する
郵便番号の自動入力が動作すること
unit test/codeception
やること
zip01-03
postal_codeに統合
db, entity, form type, twig
コントローラ等で使用している変数名
DBの列はstringで保持
バリデーション
-と数値
8文字まで入力可
-は入力後切り捨てる(KanaListenerを参考に)→DBにはハイフン無しの数値を保持
tel01-03
phone_numberに統合
db, entity, form type, twig
コントローラ等で使用している変数名
** バリデーション
-と数値
14文字まで入力可
-は、入力後切り捨てる
fax
廃止
対象テーブルdtb_customerdtb_baseinfodtb_shippingdtb_order
参考#2598
方針(Policy)
- none
実装に関する補足(Appendix)
テスト(Test)
相談(Discussion)