Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

住所や会員情報を国際標準へ対応 #2598 #3234

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
af556ec
Zip-code to postal code
toannguyen-lockon Jun 21, 2018
987544c
Remove form options
toannguyen-lockon Jun 21, 2018
53ccaf1
Fix tel function
lqdung-lockon Jun 21, 2018
186821f
Move tel to phone number
lqdung-lockon Jun 21, 2018
3cdf7ba
Change zip code to postal code
toannguyen-lockon Jun 22, 2018
7d73a66
Resolve conflict
toannguyen-lockon Jun 22, 2018
911541b
Zip code to Postal code
toannguyen-lockon Jun 22, 2018
2e01cfd
Zip code to Postal code
toannguyen-lockon Jun 22, 2018
1ab8ffb
Revert to previous commit
lqdung-lockon Jun 22, 2018
ad1bf62
Merge branch 'sf-w27-zip-code-to-postal' of https://github.com/eccube…
lqdung-lockon Jun 22, 2018
94db7c1
Remove un-use
lqdung-lockon Jun 22, 2018
022258a
Fix shipping
lqdung-lockon Jun 22, 2018
807dad1
Fix auto complete postal code
toannguyen-lockon Jun 22, 2018
f622633
Merge remote-tracking branch 'eccube-vn/sf-w27-zip-code-to-postal' in…
toannguyen-lockon Jun 22, 2018
01d70d8
Translate postal code message
toannguyen-lockon Jun 22, 2018
81e7a5c
Fix layout
lqdung-lockon Jun 22, 2018
8b4677d
Merge remote-tracking branch 'vn/sf-w27-zip-code-to-postal' into sf-w…
lqdung-lockon Jun 22, 2018
8c2928d
Merge branch 'sf-w27-zip-code-to-postal' of https://github.com/eccube…
toannguyen-lockon Jun 22, 2018
5d61bb3
Fix php-cs
toannguyen-lockon Jun 22, 2018
a659cb3
Fix codeception, postal_code code and phone_number
toannguyen-lockon Jun 22, 2018
2b22589
Fix unit test
lqdung-lockon Jun 22, 2018
e868564
Merge remote-tracking branch 'vn/sf-w27-zip-code-to-postal' into sf-w…
lqdung-lockon Jun 22, 2018
c14c9d3
Fix codeception
toannguyen-lockon Jun 22, 2018
b77cffe
Remove func unnecessary in codeception
toannguyen-lockon Jun 22, 2018
3a0e2a7
Remove unnecessary message key.
toannguyen-lockon Jun 25, 2018
37770eb
Fix layout customer
lqdung-lockon Jun 25, 2018
aa29597
Fix shopping\index.twig conflict
lqdung-lockon Jun 26, 2018
71ec5a4
Fix shopping\index.twig conflict
lqdung-lockon Jun 26, 2018
e624252
tel/zip/faxの修正漏れ対応
kiy0taka Jun 27, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions app/config/eccube/packages/eccube.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,8 @@ parameters:
eccube_product_order_newer: 2
eccube_product_order_price_higher: 3
eccube_price_max: 2147483647
eccube_tel_len: 5
eccube_tel_len_min: 1
eccube_zip01_len: 3
eccube_zip02_len: 4
eccube_tel_len_max: 14
eccube_postal_code: 8
eccube_password_min_len: 8
eccube_password_max_len: 32
eccube_composer_memory_limit: 1536
Expand Down
26 changes: 5 additions & 21 deletions codeception/_support/Page/Admin/CustomerEditPage.php
Original file line number Diff line number Diff line change
Expand Up @@ -53,15 +53,10 @@ public function 入力_メイ($value)
return $this;
}

public function 入力_郵便番号1($value)
public function 入力_郵便番号($value)
{
$this->tester->fillField(['id' => 'admin_customer_zip_zip01'], $value);
return $this;
}
$this->tester->fillField(['id' => 'admin_customer_postal_code'], $value);

public function 入力_郵便番号2($value)
{
$this->tester->fillField(['id' => 'admin_customer_zip_zip02'], $value);
return $this;
}

Expand Down Expand Up @@ -89,21 +84,10 @@ public function 入力_Eメール($value)
return $this;
}

public function 入力_電話番号1($value)
{
$this->tester->fillField(['id' => 'admin_customer_tel_tel01'], $value);
return $this;
}

public function 入力_電話番号2($value)
public function 入力_電話番号($value)
{
$this->tester->fillField(['id' => 'admin_customer_tel_tel02'], $value);
return $this;
}
$this->tester->fillField(['id' => 'admin_customer_phone_number'], $value);

public function 入力_電話番号3($value)
{
$this->tester->fillField(['id' => 'admin_customer_tel_tel03'], $value);
return $this;
}

Expand All @@ -125,4 +109,4 @@ public function 登録()
return $this;
}

}
}
2 changes: 1 addition & 1 deletion codeception/_support/Page/Admin/CustomerManagePage.php
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public function 詳細検索_電話番号($value = '')
{
$this->tester->click(self::$詳細検索ボタン);
$this->tester->wait(1);
$this->tester->fillField(['id' => 'admin_search_customer_tel'], $value);
$this->tester->fillField(['id' => 'admin_search_customer_phone_number'], $value);
$this->tester->click(self::$検索ボタン);
$this->tester->see('会員マスター会員管理', '.c-pageTitle');
return $this;
Expand Down
24 changes: 4 additions & 20 deletions codeception/_support/Page/Admin/OrderEditPage.php
Original file line number Diff line number Diff line change
Expand Up @@ -63,15 +63,10 @@ public function 入力_メイ($value)
return $this;
}

public function 入力_郵便番号1($value)
public function 入力_郵便番号($value)
{
$this->tester->fillField(['id' => 'order_zip_zip01'], $value);
return $this;
}
$this->tester->fillField(['id' => 'order_postal_code'], $value);

public function 入力_郵便番号2($value)
{
$this->tester->fillField(['id' => 'order_zip_zip02'], $value);
return $this;
}

Expand All @@ -93,21 +88,10 @@ public function 入力_番地_ビル名($value)
return $this;
}

public function 入力_電話番号1($value)
{
$this->tester->fillField(['id' => 'order_tel_tel01'], $value);
return $this;
}

public function 入力_電話番号2($value)
public function 入力_電話番号($value)
{
$this->tester->fillField(['id' => 'order_tel_tel02'], $value);
return $this;
}
$this->tester->fillField(['id' => 'order_phone_number'], $value);

public function 入力_電話番号3($value)
{
$this->tester->fillField(['id' => 'order_tel_tel03'], $value);
return $this;
}

Expand Down
2 changes: 1 addition & 1 deletion codeception/_support/Page/Admin/OrderManagePage.php
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public function 詳細検索_電話番号($value = '')
{
$this->tester->click(self::$詳細検索ボタン);
$this->tester->wait(1);
$this->tester->fillField(['id' => 'admin_search_order_tel'], $value);
$this->tester->fillField(['id' => 'admin_search_order_phone_number'], $value);
$this->tester->click('#search_form #search_submit');
return $this;
}
Expand Down
24 changes: 4 additions & 20 deletions codeception/_support/Page/Admin/ShippingEditPage.php
Original file line number Diff line number Diff line change
Expand Up @@ -70,15 +70,10 @@ public function 入力_メイ($value)
return $this;
}

public function 入力_郵便番号1($value)
public function 入力_郵便番号($value)
{
$this->tester->fillField(['id' => 'shipping_zip_zip01'], $value);
return $this;
}
$this->tester->fillField(['id' => 'shipping_postal_code'], $value);

public function 入力_郵便番号2($value)
{
$this->tester->fillField(['id' => 'shipping_zip_zip02'], $value);
return $this;
}

Expand All @@ -100,21 +95,10 @@ public function 入力_番地_ビル名($value)
return $this;
}

public function 入力_電話番号1($value)
{
$this->tester->fillField(['id' => 'shipping_tel_tel01'], $value);
return $this;
}

public function 入力_電話番号2($value)
public function 入力_電話番号($value)
{
$this->tester->fillField(['id' => 'shipping_tel_tel02'], $value);
return $this;
}
$this->tester->fillField(['id' => 'shipping_phone_number'], $value);

public function 入力_電話番号3($value)
{
$this->tester->fillField(['id' => 'shipping_tel_tel03'], $value);
return $this;
}

Expand Down
2 changes: 1 addition & 1 deletion codeception/_support/Page/Admin/ShippingManagePage.php
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public function 詳細検索_電話番号($value = '')
{
$this->tester->click(self::$詳細検索ボタン);
$this->tester->wait(1);
$this->tester->fillField(['id' => 'admin_search_shipping_tel'], $value);
$this->tester->fillField(['id' => 'admin_search_shipping_phone_number'], $value);
$this->tester->click('#search_form > div.c-outsideBlock__contents.mb-3 > button');
return $this;
}
Expand Down
24 changes: 4 additions & 20 deletions codeception/_support/Page/Admin/TradelawSettingPage.php
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,10 @@ public function 入力_運営責任者($value)
return $this;
}

public function 入力_郵便番号1($value)
public function 入力_郵便番号($value)
{
$this->tester->fillField(['id' => 'tradelaw_zip_zip01'], $value);
return $this;
}
$this->tester->fillField(['id' => 'tradelaw_postal_code'], $value);

public function 入力_郵便番号2($value)
{
$this->tester->fillField(['id' => 'tradelaw_zip_zip02'], $value);
return $this;
}

Expand All @@ -61,21 +56,10 @@ public function 入力_番地_ビル名($value)
return $this;
}

public function 入力_電話番号1($value)
{
$this->tester->fillField(['id' => 'tradelaw_tel_tel01'], $value);
return $this;
}

public function 入力_電話番号2($value)
public function 入力_電話番号($value)
{
$this->tester->fillField(['id' => 'tradelaw_tel_tel02'], $value);
return $this;
}
$this->tester->fillField(['id' => 'tradelaw_phone_number'], $value);

public function 入力_電話番号3($value)
{
$this->tester->fillField(['id' => 'tradelaw_tel_tel03'], $value);
return $this;
}

Expand Down
27 changes: 6 additions & 21 deletions codeception/_support/Page/Front/CustomerAddressAddPage.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<?php

/*
* This file is part of EC-CUBE
*
Expand Down Expand Up @@ -62,15 +63,10 @@ public function 入力_メイ($value)
return $this;
}

public function 入力_郵便番号1($value)
public function 入力_郵便番号($value)
{
$this->tester->fillField(['id' => 'shopping_shipping_zip_zip01'], $value);
return $this;
}
$this->tester->fillField(['id' => 'shopping_shipping_postal_code'], $value);

public function 入力_郵便番号2($value)
{
$this->tester->fillField(['id' => 'shopping_shipping_zip_zip02'], $value);
return $this;
}

Expand All @@ -92,26 +88,15 @@ public function 入力_番地_ビル名($value)
return $this;
}

public function 入力_電話番号1($value)
public function 入力_電話番号($value)
{
$this->tester->fillField(['id' => 'shopping_shipping_tel_tel01'], $value);
return $this;
}
$this->tester->fillField(['id' => 'shopping_shipping_phone_number'], $value);

public function 入力_電話番号2($value)
{
$this->tester->fillField(['id' => 'shopping_shipping_tel_tel02'], $value);
return $this;
}

public function 入力_電話番号3($value)
{
$this->tester->fillField(['id' => 'shopping_shipping_tel_tel03'], $value);
return $this;
}

public function 登録する()
{
$this->tester->click('#detail_box__insert_button > button');
}
}
}
26 changes: 5 additions & 21 deletions codeception/_support/Page/Front/CustomerAddressEditPage.php
Original file line number Diff line number Diff line change
Expand Up @@ -62,15 +62,10 @@ public function 入力_メイ($value)
return $this;
}

public function 入力_郵便番号1($value)
public function 入力_郵便番号($value)
{
$this->tester->fillField(['id' => 'customer_address_zip_zip01'], $value);
return $this;
}
$this->tester->fillField(['id' => 'customer_address_postal_code'], $value);

public function 入力_郵便番号2($value)
{
$this->tester->fillField(['id' => 'customer_address_zip_zip02'], $value);
return $this;
}

Expand All @@ -92,26 +87,15 @@ public function 入力_番地_ビル名($value)
return $this;
}

public function 入力_電話番号1($value)
{
$this->tester->fillField(['id' => 'customer_address_tel_tel01'], $value);
return $this;
}

public function 入力_電話番号2($value)
public function 入力_電話番号($value)
{
$this->tester->fillField(['id' => 'customer_address_tel_tel02'], $value);
return $this;
}
$this->tester->fillField(['id' => 'customer_address_phone_number'], $value);

public function 入力_電話番号3($value)
{
$this->tester->fillField(['id' => 'customer_address_tel_tel03'], $value);
return $this;
}

public function 登録する()
{
$this->tester->click('div.ec-RegisterRole__actions button');
}
}
}
25 changes: 4 additions & 21 deletions codeception/_support/Page/Front/ShoppingNonmemberPage.php
Original file line number Diff line number Diff line change
Expand Up @@ -58,15 +58,10 @@ public function 入力_メイ($value)
return $this;
}

public function 入力_郵便番号1($value)
public function 入力_郵便番号($value)
{
$this->tester->fillField(['id' => 'nonmember_zip_zip01'], $value);
return $this;
}
$this->tester->fillField(['id' => 'nonmember_postal_code'], $value);

public function 入力_郵便番号2($value)
{
$this->tester->fillField(['id' => 'nonmember_zip_zip02'], $value);
return $this;
}

Expand Down Expand Up @@ -100,21 +95,9 @@ public function 入力_Eメール確認($value)
return $this;
}

public function 入力_電話番号1($value)
{
$this->tester->fillField(['id' => 'nonmember_tel_tel01'], $value);
return $this;
}

public function 入力_電話番号2($value)
{
$this->tester->fillField(['id' => 'nonmember_tel_tel02'], $value);
return $this;
}

public function 入力_電話番号3($value)
public function 入力_電話番号($value)
{
$this->tester->fillField(['id' => 'nonmember_tel_tel03'], $value);
$this->tester->fillField(['id' => 'nonmember_phone_number'], $value);
return $this;
}

Expand Down
16 changes: 5 additions & 11 deletions codeception/acceptance/EA04OrderCest.php
Original file line number Diff line number Diff line change
Expand Up @@ -110,14 +110,11 @@ public function order_受注編集(\AcceptanceTester $I)
->入力_姓('aaa')
->入力_セイ('アアア')
->入力_メイ('アアア')
->入力_郵便番号1('060')
->入力_郵便番号2('0000')
->入力_郵便番号('060-0000')
->入力_都道府県(['1' => '北海道'])
->入力_市区町村名('bbb')
->入力_番地_ビル名('bbb')
->入力_電話番号1('111')
->入力_電話番号2('111')
->入力_電話番号3('111')
->入力_電話番号('111-111-111')
->入力_番地_ビル名('address 2')
->入力_支払方法(['4' => '郵便振替'])
->受注情報登録();
Expand Down Expand Up @@ -250,18 +247,15 @@ public function order_受注登録(\AcceptanceTester $I)
->入力_名('order1')
->入力_セイ('アアア')
->入力_メイ('アアア')
->入力_郵便番号1('060')
->入力_郵便番号2('0000')
->入力_郵便番号('060-0000')
->入力_都道府県(['1' => '北海道'])
->入力_市区町村名('bbb')
->入力_番地_ビル名('bbb')
->入力_Eメール('test@test.com')
->入力_電話番号1('111')
->入力_電話番号2('111')
->入力_電話番号3('111')
->入力_電話番号('111-111-111')
->商品検索('パーコレーター')
->商品検索結果_選択(1)
->入力_支払方法(['4'=> '郵便振替'])
->入力_支払方法(['4' => '郵便振替'])
->受注情報登録();

$I->see('受注情報を保存しました。', OrderEditPage::$登録完了メッセージ);
Expand Down
Loading