Entity拡張時にオリジナルのファイルを優先して参照するよう変更 #4711
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要(Overview・Refs Issue)
#4708
実装に関する補足(Appendix)
Eccube\Entity\*
なら%kernel.project_dir%/src/Eccube/Entity
を参照。Customize\Entity\*
なら%kernel.project_dir%/app/Customize/Entity
を参照。Plugin\[PluginCode]\Entity\*
なら%kernel.project_dir%/app/Plugin/[PluginCode]/Entity
を参照。ReflectionClass::getFileName()
を参照。テスト(Test)
ユニットテストを実装してみたものの、テスト時は元々オリジナルのファイルを参照するため実証不可につき
self::markTestSkipped()
。実際に
$ php bin:console eccube:generate:proxy
を実行する限りでは、本体もカスタマイズもプラグインもオリジナルファイルの変更に追従するようになった。マイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目