-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.1] EC-CUBEインストール時にAjaxでプラグインを有効化する #4786
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 有効期限を書き込んだファイルを生成する - 有効化URLでファイルの存在と有効期限をチェックをする - .ht から始まるファイル名なので, Apache の場合は外部から参照できない
プラグイン有効化URLのチェックを追加
okazy
force-pushed
the
feat/plugin-install
branch
from
December 7, 2020 09:31
af928c7
to
7ddcd6b
Compare
okazy
force-pushed
the
feat/plugin-install
branch
from
December 8, 2020 00:17
7ddcd6b
to
ef0406e
Compare
okazy
changed the title
[WIP] [4.1] EC-CUBEインストール時にAjaxでプラグインを有効化する
[4.1] EC-CUBEインストール時にAjaxでプラグインを有効化する
Dec 8, 2020
kiy0taka
suggested changes
Dec 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dtb_plugin.csv
の変更もお願いします。
@kiy0taka ありがとうございます! |
パッケージ後の
|
kiy0taka
approved these changes
Dec 8, 2020
kiy0taka
suggested changes
Dec 8, 2020
okazy
force-pushed
the
feat/plugin-install
branch
from
December 8, 2020 07:16
d1b0c30
to
ddf4fa8
Compare
ありがとうございます!パッケージし直しました。 |
kiy0taka
approved these changes
Dec 8, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要(Overview・Refs Issue)
EC-CUBEインストール時にAjaxでプラグインを有効化します。
関連
#4744
#4733
方針(Policy)
実装に関する補足(Appendix)
APP_ENVとキャッシュの関係でAjaxで別リクエストで処理しています。
キャッシュの生成と削除を同じリクエストでできなかったため、キャッシュ削除のリクエストも別で用意しています。
テスト(Test)
パッケージからEC-CUBEをインストールしてWebAPIプラグインが有効になっていることを確認しました。
パッケージは以下からダウンロードできます。
https://github.com/okazy/ec-cube/releases/tag/v4.1-beta.2
相談(Discussion)
WebAPIベタがきで良いか -> βではベタがきで良い
マイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目