Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SC_FormParam::setHtmlDispNameArray() の判定が不適切 #111

Closed
seasoftjapan opened this issue Jan 13, 2017 · 1 comment
Closed

SC_FormParam::setHtmlDispNameArray() の判定が不適切 #111

seasoftjapan opened this issue Jan 13, 2017 · 1 comment
Assignees
@seasoftjapan
Labels
bug:Low
Milestone
2.13.6

Comments

@seasoftjapan
Copy link
Contributor

seasoftjapan commented Jan 13, 2017 •
edited
Loading

誤
if ($this->arrDefault[$key] != '') {
正
if (strlen($this->arrDefault[$key]) >= 1) {

このバグを回避するため、LC_Page_Admin_Products_UploadCSV#lfSetParamDefaultValue() において、$arrCSVFrame[$key]['default'] = '0'; のように、数値を文字列としている。
@seasoftjapan seasoftjapan changed the title lfSetParamDefaultValue() per4 LC_Page_Admin_Products_UploadCSV#lfSetParamDefaultValue() 整数で設定できない Jan 13, 2017
@seasoftjapan seasoftjapan changed the title LC_Page_Admin_Products_UploadCSV#lfSetParamDefaultValue() 整数で設定できない SC_FormParam::setHtmlDispNameArray() の判定が不適切 Jan 13, 2017
@Yangsin Yangsin added this to the eccube-2.13.6 milestone Jan 13, 2017
@seasoftjapan seasoftjapan self-assigned this Apr 18, 2020
seasoftjapan added a commit to seasoftjapan/eccube-2_13 that referenced this issue Apr 18, 2020
@seasoftjapan
refs EC-CUBE#111 SC_FormParam::setHtmlDispNameArray() の判定が不適切
b733ac9 
値のセット側 (例: `$arrCSVFrame[$key]['default'] = '0';`) は、必ずしも誤りでないので変更を見送った。
okazy added a commit that referenced this issue May 18, 2020
@okazy
Merge pull request #380 from seasoftjapan/#111
0e62a0e 
refs #111 SC_FormParam::setHtmlDispNameArray() の判定が不適切
@okazy
Copy link
Contributor

okazy commented May 18, 2020 •
edited
Loading

#380 で修正されましたのでクローズします。

@okazy okazy closed this as completed May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seasoftjapan seasoftjapan

Labels
bug:Low
Projects
None yet
Milestone
2.13.6
Development

No branches or pull requests
3 participants
@seasoftjapan @Yangsin @okazy