Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SC_Helper_PurchaseのgetDelivDate中のコメントが実際の内容と微妙に合っていない #245

Closed
shutta- opened this issue Mar 3, 2019 · 2 comments
Closed

SC_Helper_PurchaseのgetDelivDate中のコメントが実際の内容と微妙に合っていない #245

shutta- opened this issue Mar 3, 2019 · 2 comments
Labels
bug:Low
Milestone
2.17.0

Comments

@shutta-
Copy link

shutta- commented Mar 3, 2019

SC_Helper_PurchaseのgetDelivDate中のコメントが、mtb_delivery_dateの内容と微妙に合っていない。
完全に一致させる必要はないと思うが、「○週間以内」の部分が、「以内」と「以降」では意味が違ってくるので、この部分だけは修正しておいた方が良いかなと。
shutta- pushed a commit to shutta-/eccube-2_13 that referenced this issue Mar 3, 2019
Fix issue of EC-CUBE#245
893daf4 
mtb_delivery_dateの内容と合うようにコメント部分を修正。
refs EC-CUBE#245
@shutta- shutta- mentioned this issue Mar 3, 2019
Merged
chihiro-adachi pushed a commit that referenced this issue Mar 4, 2019
Merge pull request #246 from shutta-/#245
6136c21 
Fix issue of #245
@chihiro-adachi chihiro-adachi added this to the 2.17.0 milestone Mar 4, 2019
@chihiro-adachi
Copy link
Contributor

#245 で対応。

@shutta-
Copy link
Author

shutta- commented Mar 4, 2019

#245 で対応。

#246 で対応ですね。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug:Low
Projects
None yet
Milestone
2.17.0
Development

No branches or pull requests
2 participants
@chihiro-adachi @shutta-