data/module内の不要なプログラムの削除及びテストの追加 #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nobuhiko
commented
Sep 22, 2017
•
nobuhiko
commented
- pearの整理
- Mobile-Detect もcomposerに変更
- fpdf と fpdi も composerに変更出来そうだが一旦ここまでにしておく
composerと重複しているdata/module/Net/UserAgentの削除 fixed #132
testは本体でされててphp7対応もされている @see https://github.com/pear/Archive_Tar/tree/master/tests
XML/SerializerのTest追加 @see https://github.com/pear/XML_Serializer
@see https://github.com/pear/File_SearchReplace ec-cube内で使われていない？
nobuhiko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.