Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

郵便関係のURL修正 (php7) #211

Merged
merged 1 commit into from
Aug 16, 2018

Conversation

izayoi256
Copy link
Contributor

@nobuhiko nobuhiko self-requested a review August 8, 2018 04:12
Copy link
Contributor

@nobuhiko nobuhiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

masterにプルリクしているので、こちらにも重複してプルリクする必要はないと思います

@izayoi256
Copy link
Contributor Author

@nobuhiko

masterにPRしたものはimprove/php7にも取り込まれるということでしょうか?最近本体開発に参加していないため、流れが分からず失礼いたしました。

こちらはクローズいたします。

@izayoi256 izayoi256 closed this Aug 8, 2018
@so-amuamu
Copy link

Merge前なのでリオープン

@so-amuamu so-amuamu reopened this Aug 8, 2018
@nobuhiko
Copy link
Contributor

nobuhiko commented Aug 8, 2018

@izayoi256
最終的にmasterにマージされるはずなので、PHP7かmasterかどちらかでよいかと

@so-amuamu so-amuamu added this to the 2.17.0 milestone Aug 8, 2018
@coveralls
Copy link

coveralls commented Aug 8, 2018

Coverage Status

Coverage remained the same at 22.435% when pulling 0ee2f65 on izayoi256:zip_url/php7 into 8d71efa on EC-CUBE:improve/php7.

@ryo-endo
Copy link
Contributor

:improve/php7 ブランチが次のバージョンになるので、こちらのプルリクで取り込みたいと思います。
レビューよろしくお願いします。

@kiy0taka kiy0taka merged commit ebe9617 into EC-CUBE:improve/php7 Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants