Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppVeyor が落ちるのを修正 #236

Merged
merged 4 commits into from
Nov 27, 2018

Conversation

nanasess
Copy link
Contributor

OpenSSL.Light 1.1.1.20181020 が依存関係でエラーになるため、 1.1.1 にバージョンを固定

see EC-CUBE/ec-cube#3952

@coveralls
Copy link

coveralls commented Nov 26, 2018

Coverage Status

Coverage remained the same at 22.435% when pulling e7d131c on nanasess:fix-appveyor into 5fedaa7 on EC-CUBE:improve/php7.

@nobuhiko nobuhiko requested review from nobuhiko and removed request for nobuhiko November 26, 2018 05:18
@chihiro-adachi
Copy link
Contributor

@nanasess Appvayorテスト自体こけてます?再実行すれば通る系でしょうか?

@nobuhiko
Copy link
Contributor

@chihiro-adachi #213

@nanasess
Copy link
Contributor Author

何年も前から HTTP_URL に / が抜けてました。。
nanasess@b0af944

@chihiro-adachi
Copy link
Contributor

@nobuhiko
#213 (comment)

この方針でしたね、すみません失念してました。

@nanasess
さっと修正できそうであればお願いします。
もしお時間かかるようでしたら、#235 はマージしてしまいますのでお声がけください。

@chihiro-adachi chihiro-adachi merged commit 8fd4cbb into EC-CUBE:improve/php7 Nov 27, 2018
@chihiro-adachi
Copy link
Contributor

@nanasess @nobuhiko マージしました。ご対応ありがとうございます。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants