Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

派生クラス側を使っていない箇所を修正 #326

Merged
merged 1 commit into from
Nov 19, 2019

Conversation

3tiles
Copy link
Contributor

@3tiles 3tiles commented Oct 21, 2019

基底クラス側を呼んでしまっている箇所を、派生クラス側(class_extends側)を使うように修正。

基底クラス側を呼んでしまっているので、派生クラス側(class_extends側)を使うように修正。
@coveralls
Copy link

Coverage Status

Coverage remained the same at 51.622% when pulling 11480d9 on 3tiles:fix-to-use-extended-class into 4be7f30 on EC-CUBE:improve/php7.

@kiy0taka kiy0taka changed the base branch from improve/php7 to master October 23, 2019 01:41
@nanasess
Copy link
Contributor

Windows の CI が落ちていますが、一時的なもののようです。
個人のリポジトリで試したところ問題なく通りました
https://github.com/nanasess/eccube-2_13/commit/11480d930f69d06d7797c4053e031674a02d2085/checks?check_suite_id=276890571

@chihiro-adachi chihiro-adachi added this to the 2.17.1 milestone Oct 29, 2019
@chihiro-adachi chihiro-adachi merged commit bcb5da2 into EC-CUBE:master Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants