管理画面ログインのバリデーションをインストーラに合わせる #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nanasess
commented
Nov 5, 2019
•
nanasess
commented
- 記号を含むIDがログインエラーになってしまうのを修正
- インストーラでは記号を含むIDを作成可能
- インストーラの E2E テストを追加
- Db モジュール追加
- Codeception のパラメータに環境変数を追加
- E2Eテストがエラーになるため、 インストーラで定数の初期値を設定 #329 の修正をマージ
インストーラで定数の初期値を設定
- DBHOST を DBSERVER に変更
nobuhiko
approved these changes
Nov 5, 2019
|
AppVeyor/Travis-CIが通っているのでマージします。 GitHubActionsについては以下を参照。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.