Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SameSite cookie support #374

Merged
merged 7 commits into from
Feb 13, 2020
Merged

SameSite cookie support #374

merged 7 commits into from
Feb 13, 2020

Commits on Feb 7, 2020

  1. SameSite cookie support 

    - TODO PHP7.3 or higher
- SameSite=None を未サポートの UA 向けに, SameSite 属性を削除した cookie を発行する
- SameSite=None が SameSite=Strict と見なされて cookie が拒否された場合は, 互換用の cookie を読み込む
    @nanasess
    nanasess committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    c116980 View commit details
    Browse the repository at this point in the history

  2. 管理画面ログイン修正

    @nanasess
    nanasess committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    b602cf8 View commit details
    Browse the repository at this point in the history

  3. 互換用 Cookie も SameSite=None がついてしまっていたのを修正

    @nanasess
    nanasess committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    cb44b52 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2020

  1. ログ出力削除

    @nanasess
    nanasess committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    00a6726 View commit details
    Browse the repository at this point in the history

  2. PHP7.3 or higher support 

    - secure オプションが無い場合は SameSite を空で送る
- 互換用 cookie は secure オプション必須にする
    @nanasess
    nanasess committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    8ff48a4 View commit details
    Browse the repository at this point in the history

  3. 互換用 cookie を読み込んだあとは削除する

    @nanasess
    nanasess committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    d3cd7dd View commit details
    Browse the repository at this point in the history

  4. コメント修正

    @nanasess
    nanasess committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    bf2bac1 View commit details
    Browse the repository at this point in the history