Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

不適切な strlen の使用を修正 #439

Merged
merged 1 commit into from Feb 25, 2021
Merged

不適切な strlen の使用を修正 #439

merged 1 commit into from Feb 25, 2021

Conversation

nanasess
Copy link
Contributor

  • $other_deliv_id が空文字の場合は 1, 1以上の数値の場合は 0 を返すため、一応正常に動いていた
  • PHP8 では動かない

@nanasess
不適切な strlen の使用を修正
57decfc 
- PHP8 では動かない
@okazy okazy added the bug:Low label Feb 19, 2021
@okazy okazy added this to the 2.17.2 milestone Feb 19, 2021
@okazy okazy merged commit 58841f5 into EC-CUBE:master Feb 25, 2021
@okazy
Copy link
Contributor

okazy commented Feb 25, 2021

ありがとうございます。マージしました。

@okazy okazy mentioned this pull request Mar 3, 2021
Open
@nanasess nanasess deleted the fix-address branch October 3, 2022 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nobuhiko nobuhiko nobuhiko approved these changes

Assignees
No one assigned
Labels
bug:Low
Projects
None yet
Milestone
2.17.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nanasess @okazy @nobuhiko