ADMIN_DIR をランダム文字列でテストする #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nanasess
commented
Mar 29, 2021
nanasess
commented
- ADMIN_DIR を admin 固定ではなく、ランダム文字列とする
- ビルトインウェブサーバーではなく、 symfony local web server + php-fpm を使用する
- E2Eテストを https でテストする
- E2Eテストでのシステムエラー修正 #452
カテゴリが1件しか生成されず, システムエラーになる場合があったのを修正
symfony/cli + php-fpm を使用する
nobuhiko
approved these changes
Mar 29, 2021
|
ありがとうございます。マージしました。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.