Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

エラー画面の改善 #463

Merged
merged 2 commits into from Jun 23, 2021
Merged

エラー画面の改善 #463

merged 2 commits into from Jun 23, 2021

Conversation

nanasess
Copy link
Contributor

@nanasess nanasess commented May 27, 2021

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2021

Codecov Report

Merging #463 (60d151d) into master (86812bb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #463   +/-   ##
=======================================
  Coverage   53.89%   53.89%           
=======================================
  Files          76       76           
  Lines        8992     8992           
=======================================
  Hits         4846     4846           
  Misses       4146     4146           
Flag Coverage Δ
tests 53.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86812bb...60d151d. Read the comment docs.

@nanasess nanasess changed the title PHP5.1以下向けのファイルを削除 エラー画面の改善 May 28, 2021
@nanasess
Copy link
Contributor Author

PHPStan のエラーは #464 で対応

@okazy okazy added this to the 2.17.2 milestone Jun 21, 2021
@okazy okazy merged commit 0d0f7a2 into EC-CUBE:master Jun 23, 2021
@okazy
Copy link
Contributor

okazy commented Jun 23, 2021

ありがとうございます。マージしました。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants