Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix countable fatal error on PHP8 #501

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

nanasess
Copy link
Contributor

refs #497
PHP8 で Smarty テンプレートの count 関数が以下のエラーになる場合があるのを修正

Fatal error: Uncaught TypeError: count(): Argument #1 ($value) must be of type Countable|array, null given

> Fatal error: Uncaught TypeError: count(): Argument #1 ($value) must be of type Countable|array, null given
@nanasess nanasess marked this pull request as ready for review December 14, 2021 04:47
@nanasess nanasess mentioned this pull request Dec 14, 2021
2 tasks
@chihiro-adachi chihiro-adachi added this to the 2.17.3 milestone Jan 12, 2022
@chihiro-adachi
Copy link
Contributor

phpstanは #500 で対応済

@chihiro-adachi chihiro-adachi merged commit 41184f2 into EC-CUBE:master Jan 12, 2022
@chihiro-adachi
Copy link
Contributor

@nanasess
ありがとうございます、マージしました

@nanasess nanasess deleted the fix-count-php8 branch October 3, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants