Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenSSLの関数チェックとディレクトリ・ファイルが生成時のエラー処理の追加 #37

Merged
merged 1 commit into from Jul 20, 2020
Merged

OpenSSLの関数チェックとディレクトリ・ファイルが生成時のエラー処理の追加 #37

merged 1 commit into from Jul 20, 2020

Conversation

polidog
Copy link
Contributor

@polidog polidog commented Jul 17, 2020

ApiComplierPass:: generateKeys() で気になる部分を対応しました。

対応箇所

  • publicKey, privateKey生成時のディレクトリ・ファイルの生成に失敗した場合にExceptionを発生させる
  • OpenSSL Supportがない環境も念の為考慮して function_exists でopenssl関数があるかをチェックさせた

@kiy0taka
Copy link
Contributor

ありがとうございます！

@kiy0taka kiy0taka merged commit b4f9e10 into EC-CUBE:master Jul 20, 2020
@okazy okazy mentioned this pull request Jul 22, 2020
Open
@okazy okazy added the enhancement New feature or request label Jul 22, 2020
@okazy okazy added this to the 1.0 milestone Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiy0taka kiy0taka kiy0taka approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@polidog @kiy0taka @okazy