Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added recipe_id as a path parameter for the route /RecipeDetail #12

Merged
merged 1 commit into from
Nov 8, 2020
Merged

Added recipe_id as a path parameter for the route /RecipeDetail #12

merged 1 commit into from
Nov 8, 2020

Conversation

coder-tim
Copy link
Contributor

Added recipe_id as a path parameter for the route /RecipeDetail.

Before:
<Route path='/RecipeDetail' component={RecipeDetail} />

Now:
<Route path='/RecipeDetail/:recipe_id' component={RecipeDetail} />

yanisakham
yanisakham approved these changes Nov 8, 2020
View reviewed changes
Copy link
Contributor

@yanisakham yanisakham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coder-tim coder-tim merged commit ee830a8 into master Nov 8, 2020
@coder-tim coder-tim deleted the tim-add-path-param-for-recipe-detail branch November 8, 2020 21:53
@coder-tim coder-tim added the bug Something isn't working label Nov 15, 2020
@coder-tim coder-tim self-assigned this Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanisakham yanisakham yanisakham approved these changes

Assignees

@coder-tim coder-tim

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@coder-tim @yanisakham