Implemented basic layout and functionalities for Recipe Search Results page and Recipe Detail page #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanisakham
previously approved these changes
Nov 11, 2020
| @@ -0,0 +1 @@ | |||
| [1110/201713.186:ERROR:directory_reader_win.cc(43)] FindFirstFile: The system cannot find the path specified. (0x3) | |||
There was a problem hiding this comment.
is this supposed to be here, haha
There was a problem hiding this comment.
Oh yea, it shouldn't
| @@ -3,6 +3,7 @@ | |||
| CONSTANTS.APP_NAME = 'ChefCoPilot'; | |||
|
|
|||
| CONSTANTS.BACKEND_URL = 'https://chefcopilotbackend.herokuapp.com'; | |||
| CONSTANTS.LOCAL_HOST_BACKEND_URL = "http://localhost:3001"; | |||
There was a problem hiding this comment.
maybe for now can we just set CONSTANTS.BACKEND_UR as the local host url instead of making a local_host constant? just comment out the https://chefcopilot one
yanisakham
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current functionalities:
Recipe Search Results page currently retrieves all the recipes from our database
Recipe detail page currently has no data
The Recipe Search Results page uses the
<RecipeCard>component<RecipeCard>component can be used in your FavouritesList pageI had to make adjustments to the routes so that we could navigate between pages without any bugs related to url path names.
Please Note:
I haven't styled the components yet. I'm going to finish implementing the functionalities first before adding aesthetics to these components._
Some of the components have placeholder text on them
Recipe Search Results Page:
Recipe Detail Page:
